How to do a review of a PR
- First select one PR: https://github.com/WordPress/test-handbook/pulls
- In the PR, you should find a link to the original ticket. For example in this PR: https://github.com/WordPress/test-handbook/pull/55 you will find a link to: https://github.com/WordPress/test-handbook/issues/31
- In that link you will see which is the page being replicated. In this example this page is being replicated https://make.wordpress.org/test/handbook/get-setup-for-testing/
- Now, ideally divide your screen in two sections, in one side, put the original document and the other side, put the new PR file
- To access the new PR file, you should go to the PR -> Files Changed. In this example: https://github.com/WordPress/test-handbook/pull/55/files
- Then clock on the 3 dots -> View File. In this example it leads to: https://github.com/dhruvang21/test-handbook/blob/d04ec6869e18645a27bed279535b46b4acf7548f/get-setup-for-testing/index.md
- Now you have side by side, the new content in MD and the old content in the make.wordpress.org page.
- Check that both versions are identical. If you need to add some corrections, go back to the “Files Changed” section, and click on the lines that need a change to do a review and put a comment. Once you have added all the comments, click on Submit Review -> Request Changes -> Submit Review
- Repeat this until the doc is identical to the original
- Once everything is perfect, go to Submit Review -> Approve -> Submit Review
How to do a review of an Issue
If you see that everything is perfect and identical, just write a comment saying something like: All reviewed. Perfect
Some issues doesnt have a PR but need a Review. Check this list: https://github.com/WordPress/test-handbook/issues?q=is%3Aissue%20state%3Aopen%20label%3AReview and pick one. For this example I’m picking this: https://github.com/WordPress/test-handbook/issues/31
First one the make page in one side of your screen. In this example this page: https://make.wordpress.org/test/handbook/test-team-profile-badges/
Now in the other side of your screen open the MD file, in this example is this one: https://github.com/WordPress/test-handbook/blob/main/test-team-badge.md
Check that everything is identical.
If you find something that is wrong, you need to open a new PR with the changes. If you don’t know how to do this just add a comment with the things to change